search

bepaald / signalbackup-tools

Tool to work with Signal Backup files.
GNU General Public License v3.0
790 stars 38 forks source link

updated readme to clarify default merge password #75

Closed mivanit closed 2 years ago

bepaald commented 2 years ago

Hi!

Thanks for your effort, unfortunately this project does not accept pull requests at this time. Also:

Are you sure your output file was encrypted with the second password? This should not happen. I've just tested, and here the output will always use the input password (the first) if no new password is explicitly provided. If you can reproduce the incorrect behavior, please open an issue because that would be a bug.

This is already mention in the README, right here: https://github.com/bepaald/signalbackup-tools/blob/a81baf25b6ba63da7d30d9a239e5b4bbc8d1ab4f/README.md?plain=1#L71 Many examples follow this, with the -op [password]-part in parenthesis. I'm not yet sure how to make this more clear in the README, but I think it would be a bit too much to add the same explanation with each new example. I am now thinking of doing something like this: 


./signalbackup-tools [INPUT] [password] --output [OUTPUT] (-op [newpassword])[note]
Where hovering over the note shows a popup. Do you think that would be good enough? The note could also be an actual link, pointing to the explanation of course.

mivanit commented 2 years ago

Thanks for clarifying! I'll test again and double check what the password behavior was, I'll open an issue if I still find it to be the second and not the first.

having a note link would be more than sufficient, thanks!