search

bepronetwork / bepro-js

The repository contains a comprehensive documentation of the bepro.network ecosystem as a javascript framework. If you are new to BEPRO, you might want to check out the Website Overview or our public "Start Building" Page.
163 stars 94 forks source link

Create an NFT Marketplace for Clash of Cards .sol #135

Closed bepro-bot closed 5 months ago

bepro-bot commented 2 years ago

Create a simple Opener Object (similar to RealFevr)

Initial Rules :

*Read more in the comments

bepro-bot commented 2 years ago

@Ruiub3i reviewed this with the following message:

Needs to have its Unit tests finalized, and we need someone to help Ricardo, point of contact from clash of cards to ensure the Object has all the functions necessary. All the basic object structure is done

moshmage commented 2 years ago

@Ruiub3i This pull request is essentially a copy paste of an already existing contract, this should never happen. We either need to refactor the existing contract into a more dynamic contract to support two use cases or we should create a new contract that is deynamic enough to support the N use cases and then create the derived contracts for each case from that contract

This makes it that other people will not need to request a new contract if they don't need any customization, and still enable others to customize at will with a simple base-layer.

PS: Branch also has conflicts.