Change createNetwork to emit CreatedNetwork event

bepronetwork / bepro-js

The repository contains a comprehensive documentation of the bepro.network ecosystem as a javascript framework. If you are new to BEPRO, you might want to check out the Website Overview or our public "Start Building" Page.

164 stars 94 forks source link

Change createNetwork to emit CreatedNetwork event #136

Closed bepro-bot closed 2 years ago

bepro-bot commented 2 years ago

Change createNetwork function on the smart-contract of NetworkFactory.sol to emit the CreatedNetwork event

Change the CreatedNetwork event to emit the creators address instead of amount

jaymeschroeder commented 2 years ago

Working on this. Just need to sort out:

Which ID should be referenced by the CreatedNetwork event? I can't find an obvious ID (public variable) from the Network class.
I understand msg.sender would be the creator's address. Which address would reference the opener?

moshmage commented 2 years ago

@jaymeschroeder I would say its id is essentially its index on the networks mapping

bepro-bot commented 2 years ago

@jaymeschroeder is working on this.

bepro-bot commented 2 years ago

@moshmage, @jaymeschroeder has a solution - check your bounty