search

beproudstandupcom / pyglet

Automatically exported from code.google.com/p/pyglet
0 stars 0 forks source link

Remove unnecessary WindowEventDispatcher #118

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This class is unnecessary, it provides no implementation, only
documentation.  Removing it means:

* Moving event documentation into BaseWindow
* Moving the register_event_type(..) calls into pyglet/window/__init__.py

This means the EVENT_* constants will need to be moved also.  I propose to
remove them, as they don't provide any error-checking benefit over using
the strings (e.g. 'on_key_press' instead of event.EVENT_KEY_PRESS);
validity can be assert'd in dispatch_event() [I have added this assertion
in r1088].

Any objections?

Original issue reported on code.google.com by Alex.Hol...@gmail.com on 6 Aug 2007 at 1:05

GoogleCodeExporter commented 9 years ago 
Actually r1109, not 1088 [drastically bad typo].

Original comment by Alex.Hol...@gmail.com on 6 Aug 2007 at 1:06

GoogleCodeExporter commented 9 years ago 
Implemented in r1118.

Original comment by Alex.Hol...@gmail.com on 7 Aug 2007 at 10:26