Closed itsdevbear closed 3 months ago
[!WARNING]
Review failed
The pull request is closed.
The changes primarily involve: streamlining the generate
target in codegen.mk
by reordering mockery
execution, updating hash values in generated code files, substituting some external dependencies with local functions in specific methods, and modifying imports and directives in certain modules. Additionally, an update to go.mod
involves removing and adding dependencies.
File(s) | Changes Summary |
---|---|
build/scripts/codegen.mk |
Reordered mockery command in the generate target, ensuring it's run once rather than in a loop. |
mod/consensus-types/pkg/types/**/*.ssz.go , mod/engine-primitives/pkg/engine-primitives/withdrawal.ssz.go |
Updated hash values in generated code files. |
mod/consensus-types/pkg/types/deposit_message.go , mod/consensus-types/pkg/types/fork_data.go |
Replaced ssz package usage with local functions for computing signing roots. |
mod/consensus-types/pkg/types/signing_data.go |
Changed package name to types and updated go:generate directive paths. |
mod/primitives/go.mod |
Updated dependencies: removed fastssz and mapstructure , added yaml.v3 . |
"In the codeβs realm, a rabbit did weave, π
Ensuring dependencies would quickly leave. β³
"Mockery" now just once will hum, πΆ
A symphony of code, neatly strum. πΌ
Hashes anew, like stars in the night, β¨π
Changes ripple, shining bright!" π
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.45%. Comparing base (
e91b375
) to head (3da4037
).:exclamation: Current head 3da4037 differs from pull request most recent head 3a34697
Please upload reports for the commit 3a34697 to get more accurate results.
Summary by CodeRabbit
New Features
Refactor
Chores