berachain / beacon-kit

A modular framework for building EVM consensus clients β›΅οΈβœ¨
https://berachain.com
Other
147 stars 100 forks source link

chore(ssz): Deprecate v2 #1628

Closed itsdevbear closed 3 months ago

itsdevbear commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The changes primarily involve: streamlining the generate target in codegen.mk by reordering mockery execution, updating hash values in generated code files, substituting some external dependencies with local functions in specific methods, and modifying imports and directives in certain modules. Additionally, an update to go.mod involves removing and adding dependencies.

Changes

File(s) Changes Summary
build/scripts/codegen.mk Reordered mockery command in the generate target, ensuring it's run once rather than in a loop.
mod/consensus-types/pkg/types/**/*.ssz.go, mod/engine-primitives/pkg/engine-primitives/withdrawal.ssz.go Updated hash values in generated code files.
mod/consensus-types/pkg/types/deposit_message.go, mod/consensus-types/pkg/types/fork_data.go Replaced ssz package usage with local functions for computing signing roots.
mod/consensus-types/pkg/types/signing_data.go Changed package name to types and updated go:generate directive paths.
mod/primitives/go.mod Updated dependencies: removed fastssz and mapstructure, added yaml.v3.

"In the code’s realm, a rabbit did weave, πŸ‡
Ensuring dependencies would quickly leave. ⏳
"Mockery" now just once will hum, 🎢
A symphony of code, neatly strum. 🎼
Hashes anew, like stars in the night, ✨🌌
Changes ripple, shining bright!" 🌟


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.45%. Comparing base (e91b375) to head (3da4037).

:exclamation: Current head 3da4037 differs from pull request most recent head 3a34697

Please upload reports for the commit 3a34697 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/berachain/beacon-kit/pull/1628/graphs/tree.svg?width=650&height=150&src=pr&token=0l5iJ3ZbzV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain)](https://app.codecov.io/gh/berachain/beacon-kit/pull/1628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain) ```diff @@ Coverage Diff @@ ## main #1628 +/- ## =========================================== + Coverage 25.41% 70.45% +45.04% =========================================== Files 265 8 -257 Lines 12147 88 -12059 Branches 18 18 =========================================== - Hits 3087 62 -3025 + Misses 8895 22 -8873 + Partials 165 4 -161 ``` [see 252 files with indirect coverage changes](https://app.codecov.io/gh/berachain/beacon-kit/pull/1628/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain)