chore(da): clean up unused interface definitions

ocnc commented 1 week ago

Summary by CodeRabbit

New Features
- Introduced a method Persist in the AvailabilityStore interface for improved data persistence management.
Refactor
- Updated handling of BeaconBlockBodyT and BlobSidecarsT types within services to enhance flexibility and maintainability.
- Revised the logic flow for current epoch retrieval in staking operations for better accuracy and efficiency.
Bug Fixes
- Corrected the method of creating ABCIMiddleware to ensure proper middleware initialization and functionality consistency.

coderabbitai[bot] commented 1 week ago

Walkthrough

The recent changes involve modifications to data types and interfaces across several modules. Key updates include altering generic type definitions and interface methods in the Service struct and types.go. Additionally, there are adjustments to middleware initialization in middleware.go and logic flow in state processing for staking in state_processor_staking.go. These changes streamline type handling and interface interactions.

Changes

Files	Summary
`mod/da/pkg/da/service.go`	Modified `BeaconBlockBodyT` and `BlobSidecarsT` types in `Service` struct and `NewService` function.
`mod/da/pkg/da/types.go`	Updated `AvailabilityStore` and `BlobProcessor` interfaces, introduced the `BlobSidecar` interface, and removed some method declarations.
`mod/node-core/pkg/components/middleware.go`	Changed `ProvideABCIMiddleware` to use the constructor `NewABCIMiddleware` directly.
`mod/state-transition/pkg/core/...`	Adjusted the epoch retrieval logic in `state_processor_staking.go` by moving it to after the slot value is obtained.

Poem

In the code, the changes flow,
Types and interfaces, a fresh new glow.
Middleware calls, streamlined and tight,
Epochs now retrieved just right.
The code evolves, a steady flight,
By a rabbit’s touch, day and night.
🐇✨

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.62%. Comparing base (33a34ce) to head (d7437fb).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/berachain/beacon-kit/pull/1639/graphs/tree.svg?width=650&height=150&src=pr&token=0l5iJ3ZbzV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain)](https://app.codecov.io/gh/berachain/beacon-kit/pull/1639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain) ```diff @@ Coverage Diff @@ ## main #1639 +/- ## ======================================= Coverage 22.62% 22.62% ======================================= Files 265 265 Lines 11612 11610 -2 Branches 18 18 ======================================= Hits 2627 2627 + Misses 8856 8854 -2 Partials 129 129 ``` | [Files](https://app.codecov.io/gh/berachain/beacon-kit/pull/1639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain) | Coverage Δ | | |---|---|---| | [mod/da/pkg/da/service.go](https://app.codecov.io/gh/berachain/beacon-kit/pull/1639?src=pr&el=tree&filepath=mod%2Fda%2Fpkg%2Fda%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain#diff-bW9kL2RhL3BrZy9kYS9zZXJ2aWNlLmdv) | `0.00% <ø> (ø)` | | | [...ate-transition/pkg/core/state\_processor\_staking.go](https://app.codecov.io/gh/berachain/beacon-kit/pull/1639?src=pr&el=tree&filepath=mod%2Fstate-transition%2Fpkg%2Fcore%2Fstate_processor_staking.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain#diff-bW9kL3N0YXRlLXRyYW5zaXRpb24vcGtnL2NvcmUvc3RhdGVfcHJvY2Vzc29yX3N0YWtpbmcuZ28=) | `0.00% <ø> (ø)` | | | [mod/node-core/pkg/components/middleware.go](https://app.codecov.io/gh/berachain/beacon-kit/pull/1639?src=pr&el=tree&filepath=mod%2Fnode-core%2Fpkg%2Fcomponents%2Fmiddleware.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain#diff-bW9kL25vZGUtY29yZS9wa2cvY29tcG9uZW50cy9taWRkbGV3YXJlLmdv) | `0.00% <0.00%> (ø)` | |

berachain / beacon-kit