fix: let the create-validator command retrieve the loaded configuration.

[dezzeus]

Upon CLI bootstrapping, a PersistentPreRunE handler is added to the command in order to, among other things, load the configuration in a viper instance and store it into the command's context with a ViperContextKey key.

The create-validator command was using the wrong, but homonymous, ViperContextKey for retrieving the viper configuration from the command context.

As a result, the command implementation was not able to find some configuration values which were silently used as empty strings that, eventually, would halt the execution with unexpected errors.

This commit replaces the source package of the ViperContextKey key from github.com/cosmos/cosmos-sdk/client to github.com/berachain/beacon-kit/mod/cli/pkg/context

This should also fix the issue #2122 .

Summary by CodeRabbit

• New Features
  • Improved command for validator deposits with enhanced context management.
• Bug Fixes
  • Enhanced error handling for input conversions during deposit message creation.

[coderabbitai[bot]]

Walkthrough

The changes in this pull request focus on the create.go file within the mod/cli/pkg/commands/deposit package. The primary modification involves replacing the dependency on the client from the Cosmos SDK with the clicontext package. This affects how application options are retrieved in the getBLSSigner function, while the overall structure and functionality of the NewCreateValidator function and command execution logic remain largely unchanged.

Changes

File Path	Change Summary
mod/cli/pkg/commands/deposit/create.go	- Added import for clicontext. - Updated getBLSSigner to source AppOpts from clicontext. - No structural changes to NewCreateValidator.

Possibly related PRs

• 1655: This PR also modifies the create.go file, updating import statements and changing how AppOpts is sourced, which is directly related to the changes made in the main PR.

• 2004: This PR involves the create.go file and discusses the NewCreateValidator function, which is relevant as it pertains to the command for creating validator deposits.

• 2006: This PR adds a new command-line flag for a private key in the create.go file, which is directly related to the enhancements made in the main PR regarding command execution and user input handling.

Suggested labels

skill issue

Suggested reviewers

• itsdevbear
• ocnc

🐇 In the code we hop and play,
With clicontext leading the way.
The getBLSSigner now finds its tune,
As we dance with imports, morning to noon.
Validator commands, still strong and bright,
In our rabbit hole, everything feels right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.48%. Comparing base (50503f5) to head (8a0cd92). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
mod/cli/pkg/commands/deposit/create.go	0.00%	1 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/berachain/beacon-kit/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain) ```diff @@ Coverage Diff @@ ## main #2128 +/- ## ======================================= Coverage 23.48% 23.48% ======================================= Files 357 357 Lines 16064 16064 Branches 12 12 ======================================= Hits 3772 3772 Misses 12121 12121 Partials 171 171 ``` | [Files with missing lines](https://app.codecov.io/gh/berachain/beacon-kit/pull/2128?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain) | Coverage Δ | | |---|---|---| | [mod/cli/pkg/commands/deposit/create.go](https://app.codecov.io/gh/berachain/beacon-kit/pull/2128?src=pr&el=tree&filepath=mod%2Fcli%2Fpkg%2Fcommands%2Fdeposit%2Fcreate.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berachain#diff-bW9kL2NsaS9wa2cvY29tbWFuZHMvZGVwb3NpdC9jcmVhdGUuZ28=) | `0.00% <0.00%> (ø)` | |