search

beradeep / CollegeSearch

Android app for college search. Built using Jetpack, MVVM and Hilt.
https://github.com/beradeep/CollegeSearch/releases/download/v3.0/app-release.apk
MIT License
10 stars 2 forks source link

[feat] Dark theme implementation #2

Open beradeep opened 10 months ago

beradeep commented 10 months ago

Implement night/dark theme colors and UI for the app.

abhay-ajith commented 10 months ago

Hi, Is the issue to change the theme to dark or being able to toggle between.

beradeep commented 10 months ago

@abhay-ajith It is not an issue. The dark theme needs to be implemented as a new feature by creating a separate darkColorPalette for the dark theme. Having the option to toggle between light and dark themes is a plus.

JonibekXolmonov commented 6 months ago

Are the colors inside _darkColorScheme(now commented) real colors of dark mode?

beradeep commented 6 months ago

Yes, they were actually supposed to be the colors for dark mode. But most parts of the codebase right now has colors hardcoded only for light mode, for that reason dark mode is disabled for now. These need to be replaced with colors from the colorSchemes using MaterialTheme.colorScheme, for consistency in both the modes.

JonibekXolmonov commented 6 months ago

I give it a try.

beradeep commented 6 months ago

I give it a try.

Hi, are you working on it?

JonibekXolmonov commented 6 months ago

Hi, since you assigned me, I have been stuck in university tasks and then 2 day holiday, from tomorrow I begin working. I am so sorry to be late

beradeep commented 6 months ago

Hi, no need to be sorry 😄, thanks for informing!

JonibekXolmonov commented 6 months ago

🤝🤝

beradeep commented 5 months ago

Hi, are you still working on this?

JonibekXolmonov commented 5 months ago

Hi sir, can you unassign me? Because of my studies at the university,diploma thesis and prior-graduation practice, I can't allocate time even to breathe. As soon as I am free, I let you know and go on enhancing your project. I am really sorry not informing this earlier

beradeep commented 5 months ago

Hi, it's okay. I just wanted to know if there's any update. As per your request, I am unassigning you right now. Just let me know if you start working on this again.

JonibekXolmonov commented 5 months ago

Sure,🤝