search

berarma / ffbtools

Set of tools for FFB testing and debugging on GNU/Linux
GNU General Public License v3.0
56 stars 10 forks source link

throttling: Make throttling interval configurable #20

Closed mcoffin closed 3 years ago

mcoffin commented 3 years ago

setting the environment variable FFBTOOLS_THROTTLING_INTERVAL_MS to the number of milliseconds desired as the timer interval makes this configurable at runtime by the user, rather than solely at compile-time.

This also fixes an uncaught error case, where timer_settime fails, and ensure that the logging paths are still hit (for debugging purposes), even when an ffb event is throttled.

mcoffin commented 3 years ago

@berarma sorry this took a second, but this should be good to go now. Do note if/when merging that this PR is opened against your PR, so the way it's currently set, you'd merge in to your branch, then you'd have to merge your PR :)

Thanks for working with me on this one, I appreciate it.

berarma commented 3 years ago

@berarma sorry this took a second, but this should be good to go now. Do note if/when merging that this PR is opened against your PR, so the way it's currently set, you'd merge in to your branch, then you'd have to merge your PR :)

Thanks for working with me on this one, I appreciate it.

Thanks to you for initiating the work and helping me shape it. It's all merged.