search

berarma / new-lg4ff

Experimental Logitech force feedback module for Linux
GNU General Public License v2.0
298 stars 18 forks source link

dkms: remove REMAKE_INITRD #58

Closed Arsconyl closed 2 years ago

Arsconyl commented 2 years ago

By selecting this option, dkms attempts to add the module into the user init ramdisk. While it seems like a cool idea it is not something the module should decide by the user or distribution on their behalf.

berarma commented 2 years ago

Without this line most people will keep using the default kernel module without knowing it. They would need to remove the default module and load this one manually after each reboot. What do you suggest to avoid this situation that users will complain about?

parkerlreed commented 2 years ago

REMAKE_INITRD has been deprecated. I'm not sure what has to be done otherwise but all modules throw this warning on build now (At least on Arch)

berarma commented 2 years ago

We'll have to tell the user to update the initrd manually. AFAIK there's not unique method to update the initrd across distributions but I think there's currently only two commands to do it, initramfs and dracut. Correct me if I'm wrong.

Could you add instructions to the README considering most users don't know what an initrd is?

parkerlreed commented 2 years ago

From what I've seen the system still regenerates initramfs at least when updating the kernel on Arch. It just skips doing it on every DKMS install as that becomes redundant.

As for installing this on other distributions, I'm not sure exactly what would be needed for those.

berarma commented 2 years ago

Yes, it will, but only when the kernel is reinstalled, updated or the initrd is manually regenerated. It doesn't make much sense that it's added to the initrd just after updating the kernel but not when installing the module.

berarma commented 2 years ago

I've merged but I still have to add instructions to the README or most users won't know what to do when the driver doesn't load after a reboot.