search

berarma / new-lg4ff

Experimental Logitech force feedback module for Linux
GNU General Public License v2.0
298 stars 18 forks source link

Rebase code to Linux kernel 6.3 #72

Closed motolav closed 6 months ago

motolav commented 1 year ago

This code is untested but includes patches that are missing from the original forked code that are in the kernel

Kernel commits that were missing from the repo are 1, 2, 3

I will mark ready for review after I test it

berarma commented 1 year ago

I'll review it as soon as I can. Thanks.

motolav commented 1 year ago

Kernel 6.3 includes the ID #define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL 0xc26e with this commit so once all the 6.3 HID changes are merged I'll update the PR.

motolav commented 1 year ago

This PR is complete now and I fixed the README so it says the G923 XBOX will have FFB support in kernel 6.3.

jashton-vayu commented 1 year ago

@motolav are there any updates on this? I would like to use it with my G923. I did try building & installing your fork but did not seem to pick up the device for me on Ubuntu 20.04

berarma commented 1 year ago

@motolav are there any updates on this? I would like to use it with my G923. I did try building & installing your fork but did not seem to pick up the device for me on Ubuntu 20.04

Is it the XBox version? This driver is only for the PS version.

jashton-vayu commented 1 year ago

@berarma If I'm not mistaken, Kernel 6.3 includes support for Xbox G923, I thought that's what this rebase was providing https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.3

berarma commented 1 year ago

@berarma If I'm not mistaken, Kernel 6.3 includes support for Xbox G923, I thought that's what this rebase was providing https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.3

No, this isn't related.

motolav commented 1 year ago

@jashton-vayu The Xbox G923 wheel uses a different driver that doesn't involve any of this code and doesn't need any of the improvements that this driver has IIRC.

This module is not compatible with the Logitech G920 Driving Force and XBOX/PC version of the Logitech G923 (046d:c26d, 046d:c26e). Both wheels use the HID++ protocol and are supported by the HID++ driver as of kernel 6.3.

jashton-vayu commented 1 year ago

@motolav Is it possible to back-port the changes from 6.3 in a similar way to this PR?

motolav commented 1 year ago

@jashton-vayu you don't understand, you don't need this driver at all. As long as your distro is using kernel 6.3 you can use your wheel on Linux now without any modification. Here is the commit that added support to your wheel in the kernel if you want to bother to back-port it

berarma commented 6 months ago

@molotav, thanks for your work on this. I'm ashamed it took me so long to merge it.