berberman / nvfetcher

Generate nix sources expr for the latest version of packages
https://nvfetcher.torus.icu
MIT License
168 stars 14 forks source link

Wrong version pulled from github_tag #95

Closed viperML closed 1 year ago

viperML commented 1 year ago
[soralog]
src.github_tag = "soramitsu/soralog"
src.version = "v0.1.3"
fetch.github = "soramitsu/soralog"

I would expect this to pull the tag v0.1.3, but the following is generated:

{
    "soralog": {
        "cargoLocks": null,
        "extract": null,
        "name": "soralog",
        "passthru": null,
        "pinned": false,
        "src": {
            "deepClone": false,
            "fetchSubmodules": false,
            "leaveDotGit": false,
            "name": null,
            "owner": "soramitsu",
            "repo": "soralog",
            "rev": "v0.1.5",
            "sha256": "sha256-zjoBQLknPNlNhEIbu60nIYsEZefqmMDfg9myVsAyMq0=",
            "type": "github"
        },
        "version": "v0.1.5"
    }
}

Notice how nvfetcher will use rev 0.1.5, instead of 0.1.3

Using nvfetcher 0.5.0.0 from nixpkgs @ ab1254087f4cdf4af74b552d7fc95175d9bdbb49 (latest commit of nixos-22.11 atm)

berberman commented 1 year ago

src.version is not a valid option, which is ignored. If you want to specify a version instead of querying the latest one using nvchecker, you can use src.manual.