search

berenddeboer / cdk-rds-sql

A CDK construct that allows creating roles and databases an on Aurora Serverless Postgresql cluster.
Apache License 2.0
23 stars 11 forks source link

functionProps not passed properly anymore to provider #30

Closed aperov9 closed 2 months ago

aperov9 commented 2 months ago

Hi @berenddeboer,

I stumbled upon an issue while specifying additional NodejsFunctionProps. My code won't synthesize anymore with version 3.4.0 and throws the following error:

Lambda Functions in a public subnet can NOT access the internet. If you are aware of this limitation and would still like to place the function in a public subnet, set "allowPublicSubnet" to true

Although I specified allowPublicSubnet: true inside the functionProps it is not being passed correctly.

I was digging a bit into the code and suspect that @emmanuelnk removed the following line which was important.

Adding the line back solved my issue, please take a look at the respective PR.

emmanuelnk commented 2 months ago

Not sure I removed that line intentionally but seems to have been by mistake. Thanks for catching that. Apologies for any issues caused.