search

berenddeboer / cdk-rds-sql

A CDK construct that allows creating roles and databases an on Aurora Serverless Postgresql cluster.
Apache License 2.0
23 stars 11 forks source link

feat: extra database connection properties #34

Closed djcass44 closed 2 months ago

djcass44 commented 2 months ago

Added an option to set extra client properties when connecting to the database. This is primarily needed so that SSL/TLS can be used to connect to the database.

This change should be backwards compatible as well as if no props are set, it just won't set anything and behave exactly as it does now.

Fixes #28

I wasn't sure of a good way to test this because I couldn't find a way to get the PostgreSQL testcontainer to use TLS.

Note: this doesn't solve the issue of custom CA's that was discussed in #28, but at least we can turn SSL/TLS on. It's a start...

berenddeboer commented 2 months ago

You're sure this is not the default?? So surprised by this. But yeah, adding connections seems to be valuable in itself.

berenddeboer commented 2 months ago

I've reverted your commit as "projen build" fails with this, and ran out of time to fix. Please resubmit with proof "projen build" works.

I kept getting variations of this, whatever I tried:

[2024-09-12T09:46:40.612] [ERROR] jsii/compiler - Type model errors prevented the JSII assembly from being created
src/provider.ts:86:19 - error JSII9000: Encountered use of module that is not declared in "dependencies" or "peerDependencies": "@types/pg"

86   public readonly connectionProps: ClientConfig
                     ~~~~~~~~~~~~~~~
👾 Task "build » compile" failed when executing "jsii --silence-warnings=reserved-word" (cwd: /home/berend/src/cdk-rds-sql)
djcass44 commented 2 months ago

Looks like I mistakenly used TypeScript types that haven't been added as dependencies. That should be an easy fix! I'll get right on it

On Thu, 12 Sept 2024, 7:58 am Berend de Boer, @.***> wrote:

I've reverted your commit as "projen build" fails with this, and ran out of time to fix. Please resubmit with proof "projen build" works.

I kept getting variations of this, whatever I tried:

[2024-09-12T09:46:40.612] [ERROR] jsii/compiler - Type model errors prevented the JSII assembly from being created src/provider.ts:86:19 - error JSII9000: Encountered use of module that is not declared in "dependencies" or "peerDependencies": @.***/pg"

86 public readonly connectionProps: ClientConfig


👾 Task "build » compile" failed when executing "jsii --silence-warnings=reserved-word" (cwd: /home/berend/src/cdk-rds-sql)

—
Reply to this email directly, view it on GitHub
<https://github.com/berenddeboer/cdk-rds-sql/pull/34#issuecomment-2344774765>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJQGVQWDR5GJI753BMYNJDTZWC4G3AVCNFSM6AAAAABOAXLIJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUG43TINZWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>