search

berenddeboer / cdk-rds-sql

A CDK construct that allows creating roles and databases an on Aurora Serverless Postgresql cluster.
Apache License 2.0
23 stars 11 forks source link

feat: extra database connection properties - take 2 #35

Open djcass44 opened 2 months ago

djcass44 commented 2 months ago

This is exactly the same as #34 except it fixes the build issues.

To prove that it works, here's a screenshot of my IDE terminal: image

There are a few extra file changes in here (e.g., eslint, package-lock), those were made by progen when I ran npm run build so I figured they were supposed to be there. If not, let me know and I'll remove them.

berenddeboer commented 2 months ago

LOL, any! Hmm, I think we can do better. No way we can pull in only the valid connection properties? This is typescript after all, want want types.

djcass44 commented 2 months ago

@berenddeboer I can't for the life of me get it to build with types. It just complains that the module is not declared, despite me clearly declaring it in the .progenrc.ts:

image

@types/pg is also added into the package.json under dependencies and bundledDependencies so I have no idea what it's complaining about.

I've tried every possible combination of deps and bundledDeps but can't get it to build... Any ideas?

berenddeboer commented 2 months ago

I think we're making this way too difficult. You simply wanted ssl right?

berenddeboer commented 2 months ago

@djcass44 Please check my new PR. Could you give this a spin please?