Open mikel67 opened 1 week ago
When setting function properties for the provider the timeout is not applied and always uses the default of 5 minutes.
e.g. const rdsProvider = new Provider(this, "Provider", { vpc: vpc, cluster: cluster, vpcSubnets: vpc.selectSubnets({ subnetType: SubnetType.PUBLIC }), // eslint-disable-next-line @typescript-eslint/no-non-null-assertion secret: cluster.secret!, functionProps: { allowPublicSubnet: true, timeout: Duration.minutes(15), } });
Investigated and see that the issue is with newCustomResourceHandler (line 136)
current code: timeout: props.timeout ?? Duration.seconds(300),
fixed code: timeout: props.functionProps?.timeout ?? Duration.seconds(300),
I have tested on a local clone and the change results in the Lambda function having the expected timeout of 15 minutes. Once I get a chance to familiarise myself with the codebase and tests, will submit a PR.
When setting function properties for the provider the timeout is not applied and always uses the default of 5 minutes.
e.g. const rdsProvider = new Provider(this, "Provider", { vpc: vpc, cluster: cluster, vpcSubnets: vpc.selectSubnets({ subnetType: SubnetType.PUBLIC }), // eslint-disable-next-line @typescript-eslint/no-non-null-assertion secret: cluster.secret!, functionProps: { allowPublicSubnet: true, timeout: Duration.minutes(15), } });
Investigated and see that the issue is with newCustomResourceHandler (line 136)
current code: timeout: props.timeout ?? Duration.seconds(300),
fixed code: timeout: props.functionProps?.timeout ?? Duration.seconds(300),
I have tested on a local clone and the change results in the Lambda function having the expected timeout of 15 minutes. Once I get a chance to familiarise myself with the codebase and tests, will submit a PR.