search

berenger-eu / tbfmm

Task-based fast multipole method, parallelized using OpenMP and StarPU. With StarPU it supports multiple GPUs (CUDA).
Other
10 stars 3 forks source link

Make Test Error..!! #1

Closed Himscipy closed 4 years ago

Himscipy commented 4 years ago

Hi @berenger-eu,

Here is the details after executing make test.

Running tests...
Test project /Users/shar306/Work/Reviews/JOSS_Review/tbfmm/build
      Start  1: utest-check-kernel-constness
 1/24 Test  #1: utest-check-kernel-constness ...........   Passed    0.01 sec
      Start  2: utest-content
 2/24 Test  #2: utest-content ..........................   Passed    0.00 sec
      Start  3: utest-hilbert
 3/24 Test  #3: utest-hilbert ..........................   Passed    0.10 sec
      Start  4: utest-lipow
 4/24 Test  #4: utest-lipow ............................   Passed    0.01 sec
      Start  5: utest-morton
 5/24 Test  #5: utest-morton ...........................   Passed    0.10 sec
      Start  6: utest-p2p
 6/24 Test  #6: utest-p2p ..............................   Passed    0.04 sec
      Start  7: utest-rotationkernel-float
 7/24 Test  #7: utest-rotationkernel-float .............   Passed    0.18 sec
      Start  8: utest-rotationkernel-interaction
 8/24 Test  #8: utest-rotationkernel-interaction .......   Passed    0.09 sec
      Start  9: utest-rotationkernel-spetabaru-float
 9/24 Test  #9: utest-rotationkernel-spetabaru-float ...***Exception: SegFault  5.94 sec
      Start 10: utest-rotationkernel-spetabaru
10/24 Test #10: utest-rotationkernel-spetabaru .........***Exception: SegFault 18.63 sec
      Start 11: utest-rotationkernel-tsm
11/24 Test #11: utest-rotationkernel-tsm ...............   Passed    0.51 sec
      Start 12: utest-rotationkernel
12/24 Test #12: utest-rotationkernel ...................   Passed    0.49 sec
      Start 13: utest-template-iter
13/24 Test #13: utest-template-iter ....................   Passed    0.00 sec
      Start 14: utest-testkernel-float
14/24 Test #14: utest-testkernel-float .................   Passed    0.28 sec
      Start 15: utest-testkernel-interactioncounter
15/24 Test #15: utest-testkernel-interactioncounter ....   Passed    0.27 sec
      Start 16: utest-testkernel-interactionprinter
16/24 Test #16: utest-testkernel-interactionprinter ....   Passed    7.73 sec
      Start 17: utest-testkernel-interactiontimer
17/24 Test #17: utest-testkernel-interactiontimer ......   Passed    0.30 sec
      Start 18: utest-testkernel-periodic-tsm
18/24 Test #18: utest-testkernel-periodic-tsm ..........   Passed    1.32 sec
      Start 19: utest-testkernel-periodic
19/24 Test #19: utest-testkernel-periodic ..............   Passed    0.85 sec
      Start 20: utest-testkernel-spetabaru-float
20/24 Test #20: utest-testkernel-spetabaru-float .......***Exception: SegFault  0.09 sec
      Start 21: utest-testkernel-spetabaru-tsm
21/24 Test #21: utest-testkernel-spetabaru-tsm .........***Exception: SegFault  0.01 sec
      Start 22: utest-testkernel-spetabaru
22/24 Test #22: utest-testkernel-spetabaru .............***Exception: SegFault  0.10 sec
      Start 23: utest-testkernel-tsm
23/24 Test #23: utest-testkernel-tsm ...................   Passed    0.93 sec
      Start 24: utest-testkernel
24/24 Test #24: utest-testkernel .......................   Passed    0.28 sec

79% tests passed, 5 tests failed out of 24

Total Test time (real) =  38.83 sec

The following tests FAILED:
      9 - utest-rotationkernel-spetabaru-float (SEGFAULT)
     10 - utest-rotationkernel-spetabaru (SEGFAULT)
     20 - utest-testkernel-spetabaru-float (SEGFAULT)
     21 - utest-testkernel-spetabaru-tsm (SEGFAULT)
     22 - utest-testkernel-spetabaru (SEGFAULT)
Errors while running CTest
make: *** [test] Error 8
berenger-eu commented 4 years ago

Dear @Himscipy thanks for your feedback. Could you re-run the tests but getting the output when it fails:

# Should be something like:
CTEST_OUTPUT_ON_FAILURE=TRUE make test

The tests passed on my PC (ubuntu, clang 10.0.0).

berenger-eu commented 4 years ago

Finally, I was able to access a Mac and to get the same error, so I can try to solve it (it is still unclear if this is a bug from the compiler or from tbfmm....)

berenger-eu commented 4 years ago

Dear @Himscipy the problem has been solved (it was a bug in the lib when a C++ function name was demangled, but nothing was done when the demangling was not working). The patch has been pushed in master, but it might be necessary to clone tbfmm again because the modification is in a submodule (just to make sure everything is clean). Thanks !

berenger-eu commented 4 years ago

Dear @Himscipy I will wait your confirmation that the problem is solved to close the issue. Thanks.

Himscipy commented 4 years ago

Hi @berenger-eu, 👋

Thank you for the update, I tested the update you made and it work, Here are my output. I will close this issue, and finalize. my review.

Running tests...
Test project /Users/shar306/Work/Reviews/JOSS_Review/tbfmm/build
      Start  1: utest-check-kernel-constness
 1/24 Test  #1: utest-check-kernel-constness ...........   Passed    0.56 sec
      Start  2: utest-content
 2/24 Test  #2: utest-content ..........................   Passed    0.21 sec
      Start  3: utest-hilbert
 3/24 Test  #3: utest-hilbert ..........................   Passed    0.31 sec
      Start  4: utest-lipow
 4/24 Test  #4: utest-lipow ............................   Passed    0.23 sec
      Start  5: utest-morton
 5/24 Test  #5: utest-morton ...........................   Passed    0.34 sec
      Start  6: utest-p2p
 6/24 Test  #6: utest-p2p ..............................   Passed    0.25 sec
      Start  7: utest-rotationkernel-float
 7/24 Test  #7: utest-rotationkernel-float .............   Passed    0.52 sec
      Start  8: utest-rotationkernel-interaction
 8/24 Test  #8: utest-rotationkernel-interaction .......   Passed    0.42 sec
      Start  9: utest-rotationkernel-spetabaru-float
 9/24 Test  #9: utest-rotationkernel-spetabaru-float ...   Passed    8.06 sec
      Start 10: utest-rotationkernel-spetabaru
10/24 Test #10: utest-rotationkernel-spetabaru .........   Passed   19.71 sec
      Start 11: utest-rotationkernel-tsm
11/24 Test #11: utest-rotationkernel-tsm ...............   Passed    0.75 sec
      Start 12: utest-rotationkernel
12/24 Test #12: utest-rotationkernel ...................   Passed    1.11 sec
      Start 13: utest-template-iter
13/24 Test #13: utest-template-iter ....................   Passed    0.22 sec
      Start 14: utest-testkernel-float
14/24 Test #14: utest-testkernel-float .................   Passed    0.59 sec
      Start 15: utest-testkernel-interactioncounter
15/24 Test #15: utest-testkernel-interactioncounter ....   Passed    0.48 sec
      Start 16: utest-testkernel-interactionprinter
16/24 Test #16: utest-testkernel-interactionprinter ....   Passed    9.21 sec
      Start 17: utest-testkernel-interactiontimer
17/24 Test #17: utest-testkernel-interactiontimer ......   Passed    0.91 sec
      Start 18: utest-testkernel-periodic-tsm
18/24 Test #18: utest-testkernel-periodic-tsm ..........   Passed    1.61 sec
      Start 19: utest-testkernel-periodic
19/24 Test #19: utest-testkernel-periodic ..............   Passed    1.32 sec
      Start 20: utest-testkernel-spetabaru-float
20/24 Test #20: utest-testkernel-spetabaru-float .......   Passed    1.64 sec
      Start 21: utest-testkernel-spetabaru-tsm
21/24 Test #21: utest-testkernel-spetabaru-tsm .........   Passed    1.56 sec
      Start 22: utest-testkernel-spetabaru
22/24 Test #22: utest-testkernel-spetabaru .............   Passed    1.09 sec
      Start 23: utest-testkernel-tsm
23/24 Test #23: utest-testkernel-tsm ...................   Passed    0.70 sec
      Start 24: utest-testkernel
24/24 Test #24: utest-testkernel .......................   Passed    0.50 sec

100% tests passed, 0 tests failed out of 24

Total Test time (real) =  52.94 sec