search

berenslab / RFEst

A Python 3 toolbox for neural receptive field estimation using splines and Gaussian priors.
https://arxiv.org/abs/2108.07537
GNU General Public License v3.0
24 stars 3 forks source link

Incompatible with new jax version #30

Closed michaeldeistler closed 5 months ago

michaeldeistler commented 5 months ago

RFEst does from jax.config import config in almost every file. This has been deprecated a while a go and now throws an error in new jax versions. It should be replaced with from jax import config.

Aside: I would recommend to not force using float64 and instead leave this decision to the user.

huangziwei commented 5 months ago

fixed. I kept the forced float64 because it was a sensible default; RFs look crap in most of my data with float32... users can also just turn it to False manually if they want :D