search

berenslab / retinal-rl

Testing theories about retinal coding in reinforcement learning environments
GNU Affero General Public License v3.0
0 stars 1 forks source link

Variables in configs not user-friendly #59

Open fabioseel opened 4 weeks ago

fabioseel commented 4 weeks ago

Still not sure how to feel about referencing those variables here and thus forcing the experiment config to set them. This is somewhat obscure and non intuitive. However, I'm also not fundamentally happy about the alternative (just have defaults here and overwrite them in the experiment config) - even though it's more explicit and imho easier to use at first sight, intrinsic dependencies (eg vision_height and _width definition between model and dataset needs to match) can easily be messed up (but this also applies for the current system.

In general, I think this is user unfriendly and we should rediscuss and fix this somehow.

alex404 commented 4 weeks ago

Yah I have thoughts about this too but its not urgent. We can discuss next time it makes sense.