berezhinskiy / ecoflow_exporter

Prometheus exporter for EcoFlow portable power stations
GNU General Public License v3.0
188 stars 29 forks source link

Compatibility with Prometheus base units #4

Open berezhinskiy opened 1 year ago

berezhinskiy commented 1 year ago

According to best practices for naming metrics and labels, the voltage should be in volts and the current in amperes as base units. EcoFlow sends millivolts mV and milliampere mA. It is possible to convert units by exporter since all voltage, and current JSON keys have _vol and _amp suffix accordingly. The only downside here - it will break Grafana dashboard backward compatibility. A new revision will be required. Historical data will be affected as well. Still determining if the game is worth the candle.