search

bergben / ng2-img-max

Angular 2 module to resize images down to a certain width and height or to reduce the quality to fit a certain maximal filesize - all in the browser.
MIT License
83 stars 46 forks source link

update to angular 13 #56

Closed dfa1234 closed 2 years ago

dfa1234 commented 2 years ago

library build with ng-packagr

dfa1234 commented 2 years ago

55 Hi here what I propose

bergben commented 2 years ago

Nice @dfa1234 thanks!

Did you test the library? Want to release a new version?

bergben commented 2 years ago

A new Demo on Plunkr (or now rather Stackblitz) would be nice? See readme

dfa1234 commented 2 years ago

@bergben You are perfectly right, before all I wanted to prepare a demo on stackblitz. I hope there will be no regression!

For you question on ng2-pica, the problem is that I could not do npm i ng2-pica in this project anymore. I think the problem is that ng2-pica need to be upgraded as well with the new angular. To move quicker I simply took your service from ng2-pica and moved it here, made some upgrade on the script (typescript related) and imported pica directly. It's the main change I did in the source code.

I keep you updated when I have a stackbliz working, but I'm also very short on time likely, I expect to work on it next week.