search

bergercookie / asm-lsp

Language server for NASM/GAS/GO Assembly
https://crates.io/crates/asm-lsp
BSD 2-Clause "Simplified" License
272 stars 18 forks source link

fix: Add additional global config path on macos #130

Closed WillLillis closed 3 months ago

WillLillis commented 3 months ago

Currently the server uses the dirs crate to find the global configuration path. On MacOS this is unintuitively $HOME/Library/Application Support/. This PR adds $HOME/.config as an additional directory to search if the first check comes up empty.

cc @JezerM I don't have a Mac to test this locally. If you have the time, could you check if this resolves the behavior outlined in #127?

EDIT: Not sure why CI is failing, everything is passing locally in Ubuntu. Give me a minute to work this out :)

JezerM commented 3 months ago

I can confirm it works. I placed the config at ~/.config/asm-lsp/.asm-lsp.toml with no project overrides.

Captura de pantalla 2024-08-26 a la(s) 21 26 42
WillLillis commented 3 months ago

I can confirm it works. I placed the config at ~/.config/asm-lsp/.asm-lsp.toml with no project overrides.

Captura de pantalla 2024-08-26 a la(s) 21 26 42

Great, thank you!