search

bergercookie / asm-lsp

Language server for NASM/GAS/GO Assembly
https://crates.io/crates/asm-lsp
BSD 2-Clause "Simplified" License
239 stars 13 forks source link

feat: VSCode dev support #97

Closed WillLillis closed 2 months ago

WillLillis commented 2 months ago

I haven't personally spent much time with VSCode (so I may be missing some fairly obvious gotcha's here), but it's an incredibly popular editor and it would be really nice to enable its users to try out our server. After some tinkering I was able to get a development debug build to work:

image

I pieced this together by looking over similar implementations in htmx-lsp and surrealql-lsp. (Both are well-worth checking out)

cc: @Ce11an, I got most of the way there by copying your implementation in surrealql-lsp. Hope that's ok 😄

Ce11an commented 2 months ago

I haven't personally spent much time with VSCode (so I may be missing some fairly obvious gotcha's here), but it's an incredibly popular editor and it would be really nice to enable its users to try out our server. After some tinkering I was able to get a development debug build to work:

image

I pieced this together by looking over similar implementations in htmx-lsp and surrealql-lsp. (Both are well-worth checking out)

cc: @Ce11an, I got most of the way there by copying your implementation in surrealql-lsp. Hope that's ok 😄

Of course! I copied the majority from rust-analyzer 😆

P.S. I also added bits into the CI to check for linting and formatting errors. As well as making sure the package can be built. Not too much effort to add in if you fancied it.

WillLillis commented 2 months ago

Of course! I copied the majority from rust-analyzer 😆

😆

P.S. I also added bits into the CI to check for linting and formatting errors. As well as making sure the package can be built. Not too much effort to add in if you fancied it.

Awesome! I'll spend some time trying to get that working with the existing CI now :)