[FEATURE] Suppot CatServer 1.18.2

silverfox0000 commented 1 year ago

BkCommonLib version: 1.19.3-v2-SNAPSHOT (build: 1454)

Spigot version: 1.18.2

Problem or bug:

Not supporting 1.18.2 CatServer (It makes sense that it would not start)

Expected behaviour:

Crash xD
Steps to reproduce:
- Install CatServer 1.18.2 from jenkins
- Install plugin
- Get an a really big error

EDIT: Forgot add logs link https://pastebin.com/hZmCFJSu

bergerkiller commented 1 year ago

There's sadly still several problems in CatServer 1.18.2's remapper. It's chinese newyear currently so I doubt they have the time at the moment to fix all these issues. I did fix one problem in bkcl itself that caused some trouble.

Fixes some core problems: https://ci.mg-dev.eu/job/BKCommonLib/1455/

The problems that remain are all due to CatServers remapper, and not bkcl. I know because the exact same logic does work on Magma 1.18.2 and ArcLight 1.18.2. You can open an issue ticket there and crosslink with here and stuff.

Stuff like this needs to be fixed on their end where the getPlayer() isn't remapped to a proper forge method name (using the remapper):


java.lang.NoSuchMethodException: net.minecraft.server.network.ServerPlayerConnection.getPlayer()
    at java.lang.Class.getDeclaredMethod(Class.java:2675) ~[?:?]
    at com.bergerkiller.mountiplex.reflection.util.asm.MPLType$HelperImpl.getDeclaredMethod(Unknown Source) ~[?:?]
    at com.bergerkiller.mountiplex.reflection.util.asm.MPLType.getDeclaredMethod(MPLType.java:444) ~[?:?]
    at com.bergerkiller.mountiplex.reflection.resolver.Resolver.resolveAndGetDeclaredMethod(Resolver.java:504) ~[?:?]
    at com.bergerkiller.bukkit.common.conversion.type.MC1_17_Conversion.init(MC1_17_Conversion.java:34) ~[?:?]
    at com.bergerkiller.bukkit.common.internal.CommonBootstrap.initResolvers(CommonBootstrap.java:761) ~[?:?]
    at com.bergerkiller.bukkit.common.internal.CommonBootstrap.initCommonServer(CommonBootstrap.java:270) ~[?:?]
    at com.bergerkiller.bukkit.common.Common.<clinit>(Common.java:127) ~[?:?]
    at com.bergerkiller.bukkit.common.internal.CommonPlugin.onLoad(CommonPlugin.java:534) ~[?:?]
    at org.bukkit.craftbukkit.v1_18_R2.CraftServer.loadPlugins(CraftServer.java:332) ~[forge-1.18.2-40.1.73-universal.jar%2357!/:?]
    at net.minecraft.server.dedicated.DedicatedServer.m_7038_(DedicatedServer.java:226) ~[server-1.18.2-20220404.173914-srg.jar%2352!/:?]
    at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:709) ~[server-1.18.2-20220404.173914-srg.jar%2352!/:?]
    at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:243) ~[server-1.18.2-20220404.173914-srg.jar%2352!/:?]
    at java.lang.Thread.run(Thread.java:833) [?:?]```

bbayu123 commented 1 year ago

Appears that CatServer has already did their work and fixed it. Closing issue.

bergerhealer / BKCommonLib