bergerhealer / BKCommonLib

An extensive library used in bergerhealer's plugins
Other
181 stars 45 forks source link

Error with latest Spigot Version #158

Closed JuergenUniVie closed 1 year ago

JuergenUniVie commented 1 year ago
BkCommonLib version: BKCommonLib-1.19.4-v1-SNAPSHOT-1545.jar
Spigot version: 3714-Spigot-b31949f-3ae9069 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT)

[10:23:00] [Server thread/INFO]: [BKCommonLib] Loading BKCommonLib v1.19.4-v1-SNAPSHOT
[10:23:01] [Server thread/WARN]: [BKCommonLib] A class member of org.bukkit.craftbukkit.CraftChunk was not found!
[10:23:01] [Server thread/WARN]: [BKCommonLib] Failed to find method public (Object) net.minecraft.world.level.chunk.Chunk getHandle(); - Alternatives:
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public net.minecraft.world.level.chunk.IChunkAccess getHandle(net.minecraft.world.level.chunk.ChunkStatus arg0);
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public org.bukkit.World getWorld();
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public long getInhabitedTime();
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public v1_19_R3.CraftWorld getCraftWorld();
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public org.bukkit.entity.Entity[] getEntities();
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public int hashCode();
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public int getX();
[10:23:01] [Server thread/WARN]: [BKCommonLib]   - public int getZ();
[10:23:03] [Server thread/WARN]: [BKCommonLib] A class member of net.minecraft.world.level.chunk.Chunk was not found!
[10:23:03] [Server thread/WARN]: [BKCommonLib] Failed to find field public org.bukkit.Chunk bukkitChunk; - Alternatives:
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - public boolean loaded:o;
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - public final WorldServer level:q;
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - public boolean mustNotSave;
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - public boolean needsDecoration;
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - static final org.slf4j.Logger LOGGER:l;
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - private static final net.minecraft.world.level.block.entity.TickingBlockEntity NULL_TICKER:m;
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - private boolean clientLightReady:p;
[10:23:03] [Server thread/WARN]: [BKCommonLib]   - private c postLoad:s;
bergerkiller commented 1 year ago

Hm that one is a little spooky. Ill have to look into it.

bergerkiller commented 1 year ago

This should fix it. https://ci.mg-dev.eu/job/BKCommonLib/1546/

I couldnt find anything else broken by this change, but keep an eye out. There might be a performance drop due to an increase in chunk lookups, as Chunk getHandle() is no longer a simple operation

JuergenUniVie commented 1 year ago

Thanks for the quick solution!