search

bergerhealer / BKCommonLib

An extensive library used in bergerhealer's plugins
Other
181 stars 45 forks source link

Problem with permissions (test) #38

Closed Bart-0110 closed 7 years ago

Bart-0110 commented 7 years ago
BkCommonLib version: 1.12.1-v1
Spigot version: -

Problem or bug:

I have a CI running for BKCommonLib and I'm getting these errors from the builds

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.bergerkiller.bukkit.common.ChatTextTest
[INFO] [BKCommonLib] Test running on Spigot (null) : v1_12_R1 (Minecraft 1.12.1)
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.99 sec
Running com.bergerkiller.bukkit.common.IntHashMapTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec
Running com.bergerkiller.bukkit.common.TemplateTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.417 sec
Running com.bergerkiller.bukkit.common.DataWatcherTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec
Running com.bergerkiller.bukkit.common.LogicUtilTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec
Running com.bergerkiller.bukkit.common.ReflectionTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.209 sec
Running com.bergerkiller.bukkit.common.InventoryTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec
Running com.bergerkiller.bukkit.common.ItemMaterialTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.074 sec
Running com.bergerkiller.bukkit.common.CBEntitySliceTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Running com.bergerkiller.bukkit.common.RecipeTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec
Running com.bergerkiller.bukkit.common.PacketTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec
Running com.bergerkiller.bukkit.common.BlockDataTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec
Running com.bergerkiller.bukkit.common.EntityRegistryTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
Running com.bergerkiller.bukkit.common.utils.EntityGroupingUtilTest
Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.569 sec
Running com.bergerkiller.bukkit.common.PermissionsConversionTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec <<< FAILURE!

Results :

Failed tests:   testPermissionDefaultConversion(com.bergerkiller.bukkit.common.PermissionsConversionTest): Invalid default parsed: expected NOT_OP, but got OP instead

Tests run: 59, Failures: 1, Errors: 0, Skipped: 0

Expected behaviour:

Passed permission test.

Steps to reproduce:

Start a build with maven.

bergerkiller commented 7 years ago

That bug was caused by a bug in Mountiplex before. It is very likely you have to update the Mountiplex project. If you have it locally, pull the source from github and rebuild. Otherwise maybe it needs a version bump.

Since you mentioned it running on a CI: You have to delete the local Mountiplex jar/pom files in your .m2/repository and rebuild BKCommonLib. It caches the files which can be annoying when a SNAPSHOT release version of a dependency is updated, and it fails to rebuild afterwards.

Bart-0110 commented 7 years ago

That was the problem, thanks for helping!