bergerhealer / BKCommonLib

An extensive library used in bergerhealer's plugins
Other
181 stars 45 forks source link

REFLECTION missing fields. #68

Closed mibby closed 5 years ago

mibby commented 5 years ago
BkCommonLib version: BKCommonLib dev 565
Spigot version: Paper dev 121 (Spigot 1.14.3)

Problem or bug:

[22:30:00] [Server thread/INFO]: [BKCommonLib] Loading BKCommonLib v1.14.3-v1-SNAPSHOT
[22:30:02] [Server thread/WARN]: [REFLECTION] Field 'private String b' in class net.minecraft.server.v1_14_R1.PacketPlayOutOpenWindow could not be found (no more fields)
[22:30:02] [Server thread/WARN]: [REFLECTION] Field 'private IChatBaseComponent c' in class net.minecraft.server.v1_14_R1.PacketPlayOutOpenWindow could not be found (no more fields)
[22:30:02] [Server thread/WARN]: [REFLECTION] Field 'private int d' in class net.minecraft.server.v1_14_R1.PacketPlayOutOpenWindow could not be found (no more fields)
[22:30:02] [Server thread/WARN]: [REFLECTION] Field 'private int e' in class net.minecraft.server.v1_14_R1.PacketPlayOutOpenWindow could not be found (no more fields)

Expected behaviour:

No errors at start-up.

Steps to reproduce:

Start server.

biels commented 5 years ago

Is it possible that this is preventing the whole server from accepting connections at all?

bergerkiller commented 5 years ago

Nope, it impacts part of the code that isn't actually used for anything as far as I know. Many packet classes are implemented in BKC without even being used, and the open window packet is one of them.

bergerkiller commented 5 years ago

Should be all good now. https://github.com/bergerhealer/BKCommonLib/commit/6e0170eb0a8fc23a28125edff100843a299ef1f4

https://ci.mg-dev.eu/job/BKCommonLib/573/

mibby commented 5 years ago

Thanks. I'll re-open a new ticket if there is a future reflection issue. :)