search

bergerhealer / TrainCarts

Minecarts redefined
MIT License
205 stars 63 forks source link

add enabledWorlds config option #414

Closed WakkaFlocka239 closed 3 years ago

bergerkiller commented 3 years ago

Wait, but disabledWorlds already exists. Won't this be super confusing? What if the list is empty, is it then enabled on all worlds? Or disabled on all worlds?

Also, I dont think adding DefaultWorld1 and DefaultWorld2 is a good idea because then all other worlds don't get enabled anymore. By default. Not really looking forward to everyone asking me why traincarts doesnt work and having to explain they need to set the list empty in config.yml :p

WakkaFlocka239 commented 3 years ago

Wait, but disabledWorlds already exists. Won't this be super confusing? What if the list is empty, is it then enabled on all worlds? Or disabled on all worlds?

I added this because I would much rather do

instead of this

I've addressed your comments, lmk if there's anything I missed

bbayu123 commented 3 years ago

I honestly think using a flag to change the nature of the list would be more appropriate, for example, a flag to change the blacklist into a whitelist. Up to @bergerkiller to decide though.

bergerkiller commented 3 years ago

It's tricky, but I guess there's no clean solution regardless. Having a worldname : true/false node is possible, but then how do you address the default for the worlds not listed? It just moves the problem further. So I'll agree with this solution for now of having an enabled and disabled worlds list. The updated comments are hopefully clear enough :)