search

bergerkiller / NoLagg

Prevents common lag causes on your server
27 stars 14 forks source link

Packaging issues and version detection. #14

Closed Diskmaster closed 12 years ago

Diskmaster commented 12 years ago

Okay, two issues. One, why is BKCommonLib.jar being named by version in the zip. If people are gonna update, that's gonna cause headaches as then there's multiple copies of the same library in the plugins folder.

Additionally: 15:54:52 [INFO] This server is running CraftBukkit version git-Bukkit-1.1-R4-1-g9228e37 (MC: 1.1) (Implementing API version 1.1-R5-SNAPSHOT) That's an example of a version string built from the git repo via maven directly (not a jenkins built build). 23:10:20 [INFORMATION] This server is running CraftBukkit version git-Bukkit-1.1-R4-b1938jnks (MC: 1.1) (Implementing API version 1.1-R4) That's an example of a jenkins build. All jenkins builds have the bnum tag in them.

As a result, both the supporting library and nolagg give: 15:54:53 [WARNING] Plugin 'BKCommonLib' v1.06 is too old to run on CraftBukkit build 9228 15:54:53 [WARNING] Update BKCommonLib to a newer version or look for an older build of CraftBukkit 15:54:53 [WARNING] Plugin 'NoLagg' v1.64 is too old to run on CraftBukkit build 9228 15:54:53 [WARNING] Update NoLagg to a newer version or look for an older build of CraftBukkit

So, add a configurable to the plugins to shut up the warnings?

bergerkiller commented 12 years ago

The warnings are there on purpose; new builds can and probably will break something. I'll test the newer build for compatibility issues, and if all seems well, I'll update the plugins to 'shut up' :)

And I have to set the version in the file itself, else people may use a very old version causing a lot of other plugins to break.

Diskmaster commented 12 years ago

The warnings I have no problem with. The detection is a bit broken. It's fine for anyone who uses jenkins builds, but for those of us who build from git, there's no jenkins tag in the version string to rely on. (Hence the "... to run on CraftBukkit build 9228", that's actually part of the git hashtag for the commit, which if via maven built always starts with -g instead of -b like in a jenkins build.)

bergerkiller commented 12 years ago

Since the 'warning' bit is technically in BKCommonLib, I'll have to give BKCommonLib it's own configuration in which this is set...I guess. I'll close this issue, will add something for it in a separate config.yml file for BKCommonLib. Will add a proper guidance with the message to how to disable it.