search

bergie / hallo

Simple rich text editor (contentEditable) for jQuery UI
http://hallojs.org/
MIT License
2.43k stars 318 forks source link

jquery ui question #178

Closed acornejo closed 11 years ago

acornejo commented 11 years ago

Hi,

I've been looking for a small and simple wysiwyg editor, and hallo fits the bill (the only other candidate is bootstrap-wysiwyg). Unfortunately, it has quite a few dependencies, in particular jquery-ui is huge and I don't use it for anything else.

I was wondering what features exactly from jquery-ui is hallo using, so I can either:

  1. Build a custom version of jquery-ui with only the minimal requirements of hallo.
  2. Remove the jquery-ui dependency from hallo and issue a pull-request.

I could plunge into the source code and try to figure this on my own, but it seems that instead of spending 2 hrs on this, I could ask here and get someone who is familiar with the codebase to answer this in 30 seconds.

Thanks again,

Alex

bergie commented 11 years ago

@acornejo we mainly use just the Widget Factory and Button widgets. Would be great if you can report back on the minimum build options you used, and the resulting jQuery UI size!

PerfectlyNormal commented 11 years ago

I'm evaluating hallo right now, and noticed the same. We don't use jQuery UI, and would like to avoid including it, or at least as little as possible. Did a very quick test using jquery-ui-rails.

My hallo setup is a very plain editor with just format, headings, lists and reundo. Didn't notice anything not working.

First was including jquery.ui.all, which just grabs everything available. When including just jquery.ui.button and jquery.ui.widget, the full JS file was 281161 bytes smaller, without minifying. When minifying, the difference was 146983 bytes.