Instant toolbar updates - Githubissues

bergie / hallo

Simple rich text editor (contentEditable) for jQuery UI

http://hallojs.org/

MIT License

2.43k stars 314 forks source link

Instant toolbar updates #199

Open marcobarbosa opened 11 years ago

marcobarbosa commented 11 years ago

Some refactoring here. Before this toolbar was done pretty quickly.

Removed selection logic since instant toolbar doesn't depend on it
Don't show/hide the toolbar multiple times when clicking
Show the toolbar on the parent element instead on the event coordinates
Abstracted some functions
Add and remove a CSS class before showing and hiding it. Very useful for a CSS3 transition.

Also in the link plugin:

Close the toolbar when showing the dialog (shouldn't you do that?)
Bigger dialog height

Take a look. I'm not sure if I'm supposed to include the build but it's there anyway.