search

bergie / hallo

Simple rich text editor (contentEditable) for jQuery UI
http://hallojs.org/
MIT License
2.43k stars 314 forks source link

Hallo doesn't display toolbar icons when using font-awesome 4.0.3 #212

Closed techmsi closed 9 years ago

techmsi commented 10 years ago

Hallo doesn't display toolbar icons when using font-awesome 4.0.3 because the classes have changed: http://fontawesome.io/icon/italic/

Font Awesome 4.0.3

<i class="fa fa-italic"></i>

Font Awesome 3.2.1

<i class="icon-italic"></i>

What files/lines would need to be changed in order to work with the newest font-awesome code?

joseym commented 10 years ago

:+1:

spfoos commented 10 years ago

I have a pull request #213 for this. You can also check spfoos/hallo where I'll be porting most of the UI elements to Bootstrap.

brianputz commented 10 years ago

@techmsi For a quick workaround to have this work with font awesome, I inspected the element on the hallo.js demo page and pulled the font awesome css file from there.

bergie commented 9 years ago

Fixed by #213