bergie / hallo

Simple rich text editor (contentEditable) for jQuery UI
http://hallojs.org/
MIT License
2.43k stars 316 forks source link

Pressing the Esc key loses changes #245

Open aaugustin opened 8 years ago

aaugustin commented 8 years ago

A user reported to me that changes disappear mysteriously when she edits a page in the Wagtail CMS, which relies on hallo.js for editing rich text fields.

Eventually I noticed that pressing the Esc key while editing causes the field to lose focus and also revert changes. I could confirm that's how she inadvertently lost changes.

I reported this to Wagtail and they removed that behavior here: https://github.com/torchbox/wagtail/issues/2998

Since this behavior may affect other users of hallo.js, I'm reporting here as well, even though the problem is solved by Wagtail as far as I am concerned. It appears to be intentional but it makes it very easy to lose work. Perhaps you'll want to reconsider.