bergkvist / docker-graphblas

LAGraph/GraphBLAS binaries for docker containers: https://hub.docker.com/r/graphblas/lagraph, https://hub.docker.com/r/graphblas/graphblas
2 stars 1 forks source link

Remove needless line #2

Closed marci543 closed 3 years ago

marci543 commented 4 years ago

I think that line is not necessary.

Many thanks for the image.

marci543 commented 3 years ago

@bergkvist Can you please add this small change if appropriate?

By the way the new v4.0.0draft5 is released.

bergkvist commented 3 years ago

Looks good! Okay, thanks - I'll look into publishing v4.0.0draft5 now :)

bergkvist commented 3 years ago

v4.0.0draft5 is published now: https://hub.docker.com/r/graphblas/graphblas

Note that the compiled shared library is around 4x bigger than the previous version. (448MB uncompressed vs 109MB)

I guess this significant size increase might have something to do with the CUDA support (https://github.com/DrTimothyAldenDavis/GraphBLAS/releases/tag/v4.0.0draft5)

marci543 commented 3 years ago

Thank you for the release. It might be useful to ask Tim Davis about the issue.

bergkvist commented 3 years ago

Yeah, seems like it might be because debug mode is enabled: https://github.com/DrTimothyAldenDavis/GraphBLAS/issues/18