search

berglh / ubuntu-sb-kernel-signing

Ubuntu Secure Boot Kernel Signing (MOK)
MIT License
126 stars 23 forks source link

feat: run shellcheck & add github action #14

Closed pimlie closed 1 year ago

pimlie commented 1 year ago

This PR cleans up the bash scripts by fixing all issues except SC2001 reported by shellcheck. The SC2001 issue is an info level message which I think would be nice to clean up, but left that in for now.

Also added a github action to run shellcheck to ensure there are no issues in future prs

berglh commented 1 year ago

Hi @pimlie,

Thanks for the PR, sorry I seem to have missed it in the noise. This seems well worth doing and appreciate the time you put in to check the scripts for safety with shellcheck.

I'll try to pull the branch in locally and test it out from start to finish.

The main thing I was concerned about looking at your PR was double-double quotes the with the variable assignment with default value fallback after the read prompt; testing this manually in bash seems to work. I've heard of shellcheck before, and I guess we should trust the recommendations from the experts :)

pimlie commented 1 year ago

Thanks for the review, have fixed the indentation. And yeah, some of the shellcheck recommendations might look 'off' at first. Had the exact same concerns when I first ran shellcheck :)

Thanks for sharing these scripts btw, as fyi I'm referring to your repository/scripts here: https://github.com/pimlie/ubuntu-mainline-kernel.sh#secureboot

berglh commented 1 year ago

This all LGTM. Thanks for fixing the linting.

I'm new to the GitHub workflows, in GitLab we need to enable CI on the repository for the functionality to work. Do I need to do the same here or will just including the file enable it?