search

bergsm / SunLights

Program to adjust TP-Link smart bulbs with the ambient sunlight
GNU General Public License v3.0
0 stars 0 forks source link

Consolidate Transition scripts #28

Closed bergsm closed 5 years ago

bergsm commented 5 years ago

sunrise.py, sunset.py, and night.py are redundant. They should be refactored into one script/function which the transition values can be passed to.

bergsm commented 5 years ago

In addition to consolidating the scripts, the current scheduling set up will need some adjustments as well. Instead of running sunRise.py or sunSet.py at the specified times, more than likely, the sunrise and sunset times will be passed as arguments to the transition script. This will need to be reflected in the way the scripts are scheduled in cron

bergsm commented 5 years ago

After closing this issue, need to remember to change the nightCron on the Raspberry Pi currently deployed in the field to reflect the change to the new script. The nightCron was added manually during initial installation. This will be changed when issue #7 is completed.

bergsm commented 5 years ago

Currently branch issue28 is deployed and being tested.