search

berichan / SysBot.PokemonScarletViolet

A trade bot for Pokemon Scarlet/Violet
GNU Affero General Public License v3.0
79 stars 28 forks source link

Trade Embeds #12

Closed Kingj20361 closed 1 year ago

Kingj20361 commented 1 year ago

Added Trade Embeds.

berichan commented 1 year ago

This is really cool, but I think it's beyond the scope of what I want my bot to do. There also seems to be breaking changes on functionality that don't fit well with how my bot handles notifying failed trades. Feel free to keep this on your fork and maintain this functionality, it's definitely useful for people who want this!

berichan commented 1 year ago

I don't really come back to PRs like this but it seems like this is just stolen code from Kaito's fork. Please don't pass off someone else's hard work as your own in a PR, that's such a scumbag thing to do.