kakearney
commented
3 years ago Stemming from some varinfo.dat mismatches... current issues in CMIP6-forced forecast output that need to be corrected:
- IceNH4, IceNO3, IcePhL have incorrect units (IceNH4 and IceNO3 should be mmol N m^-3 instead of mg C m^-3, and IcePhL should be mg C m^-3 instead of mg C m^-2).
- variable labeled as PAR is never used in code (all 0s in output)
- critter names used older versions, which are a little misleading for some groups. E.g. NCaS is labeled as "neocalanus spp. concentration" when it should be "On-shelf large copepod concentration"... this group is primarily intended to represent Calanus marshalae and similar large-bodied copepods, not Neocalanus specifically. Being overly species-specific with functional group labels leads to misuse of the output data.
- Critter boundary conditions weren't properly scaled on input. Should have been set to near-0 seed value, but instead were set to 1.0. (PhS and PhL were scaled to 1e-16 properly, but zooplankton and detritus were at 1.0).
The varinfo.dat files are currently stored outside of the code repo. We set it up this way so people could tailor these to individual experiments as needed without altering the primary code. However, that also allows people to make changes that are misleading when the code is compiled (like adding incorrect long names or units to state variables).
Perhaps we should add some small template files, e.g. the BESTNPZ output variables only, the ice variables, the inputs associated with a particular set of forcing, etc.