beringnpz / roms-bering-sea

ROMS source code for the Bering Sea domain, including BESTNPZ and FEAST biological modules
https://beringnpz.github.io/roms-bering-sea/
Other
7 stars 1 forks source link

Diagnostic output counters need to be checked #4

Open kakearney opened 3 years ago

kakearney commented 3 years ago

Different lines of development have lead to incompatibilities in BESTNPZ-related diagnostic output counters (i.e. the i3StatXXX indices). FEAST uses 117-121 for zooplankton loss to fish, while non-FEAST BESTNPZ tries to use the same slots (117-130) for on-exit biomass (allows advective-diffusive change to be tracked in 131-144). This is a bug that needs to be fixed.

Also, when we merged the carbon code in, we resurrected some older diagnostics that I had dropped (total production, respiration, and remin) in 146-148, plus added some carbon-specific ones in 149-150. This leaves a gap at 145; not a big problem but can lead to some weirdness since that missing all-0s output can be turned on, named, and written to file (see #2).