search

berkanakyurek / select2-bootstrap4-theme

A theme for Select2 v4 and Bootstrap 4
https://berkan52.github.io/select2-bootstrap4-theme/
MIT License
91 stars 41 forks source link

Placeholder Text Not Aligned Correctly On Multiple #8

Open Joyrex opened 6 years ago

Joyrex commented 6 years ago

The placeholder text is misaligned when using Select2 Bootstrap 4 theme in multiple (tag) mode: image Adjusting the padding-top on .select2-container--bootstrap4 .select2-selection--multiple .select2-selection__rendered from .75rem to `.50rem' aligns it correctly: image

This is using Bootstrap 4.1.1 and Select2 Bootstrap4 Theme (latest)

VictorioBerra commented 6 years ago

@joyrex thanks! Would you mind submitting a pull request with your fix?

Joyrex commented 6 years ago

I've... never done that before! I went to Pull Requests, but it appears that I would have to fork this before I could create the pull request... right?

VictorioBerra commented 6 years ago

@Joyrex

Correct, fork the repo, clone it and make changes and test your changes. Especially with CSS make sure your fix did not just break the way other things look. IE: did your change just break the positioning of the little "x" button for tags? Did your change break single select dropdowns? Try and test everything.

When you are happy with it, commit and push your changes and GitHub will show you a "create pull request" button. Its very easy.

Some things to keep in mind: