berkayk / laravel-onesignal

OneSignal Push Notifications for Laravel
505 stars 175 forks source link

Error causing Exception when debug is true #52

Closed rutkoski closed 6 years ago

rutkoski commented 7 years ago

Line 225 of OneSignalClient.php is causing an unwanted Exception (Undefined index: app_id) when debug is true.

if (!$parameters['app_id']) {
    $parameters['app_id'] = $this->appId;
}

Should it be using is_empty($parameters['app_id']), maybe?

magkopian commented 7 years ago

I have the same problem, it appears that the issue has been actually fixed though on 543f042a845569e26680b7204076240c8f61785a 17 days ago.

@berkayk Would it be possible to create a new point release, so we can receive the fix by doing a composer update?

mbardelmeijer commented 7 years ago

@berkayk a new release would be much appreciated 👍

berkayk commented 7 years ago

@mbardelmeijer created a new release. I was quite busy those times, forgot to publish a new release.