search

berkeley-cdss / berkeley-class-site

MIT License
0 stars 2 forks source link

Use alternative to rack-jekyll to run accessibility tests #25

Open phrdang opened 1 month ago

phrdang commented 1 month ago

See commit message here: https://github.com/berkeley-eecs/berkeley-class-site/pull/17/commits/e1efa4ef1b2ddd854094bac70e2c34904df64952

See also #17

cycomachead commented 1 month ago

In another non-Jekyll static app I used Rack::File directly. It was a fairly simple change, but rack::file is also throwing future deprecation warnings.

We do need a hook to ensure the Jekyll site is fully built before starting the test run. We could in CI just call Jekyll build and have a dev warning? I mean it's not as nice but in terms of workability it's not a huge deal.

I haven't looked at what updating rack-Jekyll would be but that honestly shouldn't be a huge dependency.