Feat: Student Room Preference

Reimirno commented 11 months ago

We now can set students to want or avoid certain rooms. Such preference would be respected by the seat assigning algorithm.

github-actions[bot] commented 11 months ago

Coverage for unit tests for Python 3.10

File	Stmts	Miss	Cover	Missing
server
__init__.py	42	4	90%	20–21, 46, 54
forms.py	82	17	79%	17–20, 43–45, 58–61, 93–98
models.py	153	33	78%	28, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
views.py	336	261	22%	31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
__init__.py	65	37	43%	25–52, 55, 66–86, 89
auth_controllers.py	38	25	34%	13–15, 21–47, 53–55
dev_login_controllers.py	34	23	32%	11–25, 30–39, 44–56
health_controllers.py	13	2	85%	17–18
server/services/auth
__init__.py	28	4	86%	21, 49, 54–55
server/services/canvas
__init__.py	51	35	31%	18–25, 29, 33, 37, 47–80, 84
fake_canvas.py	39	26	33%	9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
assign.py	25	20	20%	16–58
data.py	123	113	8%	9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
__init__.py	30	21	30%	18–59
smtp.py	41	11	73%	15, 28–30, 32–34, 50–53
server/services/email/templates
__init__.py	33	1	97%	20
server/services/google
__init__.py	54	29	46%	23, 31, 33, 41–44, 48–54, 58–77
server/typings
exception.py	25	9	64%	16–29, 35, 41–42, 51, 54
server/utils
date.py	7	4	43%	17–19, 30
misc.py	6	5	17%	5–9
TOTAL	1249	680	46%

Tests	Skipped	Failures	Errors	Time
16	0 :zzz:	0 :x:	0 :fire:	5.607s :stopwatch:

github-actions[bot] commented 11 months ago

Coverage for unit tests for Python 3.11

File	Stmts	Miss	Cover	Missing
server
__init__.py	42	4	90%	20–21, 46, 54
forms.py	82	17	79%	17–20, 43–45, 58–61, 93–98
models.py	153	33	78%	28, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
views.py	336	261	22%	31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
__init__.py	65	37	43%	25–52, 55, 66–86, 89
auth_controllers.py	38	25	34%	13–15, 21–47, 53–55
dev_login_controllers.py	34	23	32%	11–25, 30–39, 44–56
health_controllers.py	13	2	85%	17–18
server/services/auth
__init__.py	28	4	86%	21, 49, 54–55
server/services/canvas
__init__.py	51	35	31%	18–25, 29, 33, 37, 47–80, 84
fake_canvas.py	39	26	33%	9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
assign.py	25	20	20%	16–58
data.py	123	113	8%	9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
__init__.py	30	21	30%	18–59
smtp.py	41	11	73%	15, 28–30, 32–34, 50–53
server/services/email/templates
__init__.py	33	1	97%	20
server/services/google
__init__.py	54	29	46%	23, 31, 33, 41–44, 48–54, 58–77
server/typings
exception.py	25	9	64%	16–29, 35, 41–42, 51, 54
server/utils
date.py	7	4	43%	17–19, 30
misc.py	6	5	17%	5–9
TOTAL	1249	680	46%

Tests	Skipped	Failures	Errors	Time
16	0 :zzz:	0 :x:	0 :fire:	0.636s :stopwatch:

github-actions[bot] commented 11 months ago

Coverage for e2e tests for Python 3.10

File	Stmts	Miss	Cover	Missing
server
__init__.py	42	10	76%	12, 15–21, 26, 46, 54
forms.py	82	17	79%	17–20, 43–45, 58–61, 93–98
models.py	153	35	77%	27–30, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
views.py	336	261	22%	31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
__init__.py	65	37	43%	25–52, 55, 66–86, 89
auth_controllers.py	38	25	34%	13–15, 21–47, 53–55
dev_login_controllers.py	34	23	32%	11–25, 30–39, 44–56
health_controllers.py	13	7	46%	8, 13–18
server/services/auth
__init__.py	28	6	79%	21, 49, 54–55, 60–61
server/services/canvas
__init__.py	51	35	31%	18–25, 29, 33, 37, 47–80, 84
fake_canvas.py	39	26	33%	9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
assign.py	25	20	20%	16–58
data.py	123	113	8%	9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
__init__.py	30	21	30%	18–59
smtp.py	41	29	29%	15, 23–53
server/services/email/templates
__init__.py	33	23	30%	9–11, 14–17, 20, 30–41, 45–47
server/services/google
__init__.py	54	29	46%	23, 31, 33, 41–44, 48–54, 58–77
server/typings
exception.py	25	9	64%	16–29, 35, 41–42, 51, 54
server/utils
date.py	7	4	43%	17–19, 30
misc.py	6	5	17%	5–9
TOTAL	1249	735	41%

Tests	Skipped	Failures	Errors	Time
8	0 :zzz:	0 :x:	0 :fire:	18.539s :stopwatch:

codecov[bot] commented 11 months ago

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (2102f80) 46.34% compared to head (d3da4de) 45.55%.

Files	Patch %	Lines
server/views.py	4.16%	23 Missing :warning:
server/models.py	45.45%	6 Missing :warning:
server/services/core/data.py	0.00%	5 Missing :warning:
server/typings/exception.py	37.50%	5 Missing :warning:
server/forms.py	69.23%	4 Missing :warning:
server/services/core/assign.py	25.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #29 +/- ## ========================================== - Coverage 46.34% 45.55% -0.79% ========================================== Files 22 22 Lines 1204 1249 +45 ========================================== + Hits 558 569 +11 - Misses 646 680 +34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 11 months ago

Coverage for e2e tests for Python 3.11

File	Stmts	Miss	Cover	Missing
server
__init__.py	42	10	76%	12, 15–21, 26, 46, 54
forms.py	82	17	79%	17–20, 43–45, 58–61, 93–98
models.py	153	35	77%	27–30, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
views.py	336	261	22%	31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
__init__.py	65	37	43%	25–52, 55, 66–86, 89
auth_controllers.py	38	25	34%	13–15, 21–47, 53–55
dev_login_controllers.py	34	23	32%	11–25, 30–39, 44–56
health_controllers.py	13	7	46%	8, 13–18
server/services/auth
__init__.py	28	6	79%	21, 49, 54–55, 60–61
server/services/canvas
__init__.py	51	35	31%	18–25, 29, 33, 37, 47–80, 84
fake_canvas.py	39	26	33%	9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
assign.py	25	20	20%	16–58
data.py	123	113	8%	9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
__init__.py	30	21	30%	18–59
smtp.py	41	29	29%	15, 23–53
server/services/email/templates
__init__.py	33	23	30%	9–11, 14–17, 20, 30–41, 45–47
server/services/google
__init__.py	54	29	46%	23, 31, 33, 41–44, 48–54, 58–77
server/typings
exception.py	25	9	64%	16–29, 35, 41–42, 51, 54
server/utils
date.py	7	4	43%	17–19, 30
misc.py	6	5	17%	5–9
TOTAL	1249	735	41%

Tests	Skipped	Failures	Errors	Time
8	0 :zzz:	0 :x:	0 :fire:	19.572s :stopwatch:

github-actions[bot] commented 11 months ago

Coverage for unit tests for Python 3.12

File	Stmts	Miss	Cover	Missing
server
__init__.py	42	4	90%	20–21, 46, 54
forms.py	82	17	79%	17–20, 43–45, 58–61, 93–98
models.py	153	33	78%	28, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
views.py	336	261	22%	31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
__init__.py	65	37	43%	25–52, 55, 66–86, 89
auth_controllers.py	38	25	34%	13–15, 21–47, 53–55
dev_login_controllers.py	34	23	32%	11–25, 30–39, 44–56
health_controllers.py	13	2	85%	17–18
server/services/auth
__init__.py	28	4	86%	21, 49, 54–55
server/services/canvas
__init__.py	51	35	31%	18–25, 29, 33, 37, 47–80, 84
fake_canvas.py	39	26	33%	9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
assign.py	25	20	20%	16–58
data.py	123	113	8%	9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
__init__.py	30	21	30%	18–59
smtp.py	41	11	73%	15, 28–30, 32–34, 50–53
server/services/email/templates
__init__.py	33	1	97%	20
server/services/google
__init__.py	54	29	46%	23, 31, 33, 41–44, 48–54, 58–77
server/typings
exception.py	25	9	64%	16–29, 35, 41–42, 51, 54
server/utils
date.py	7	4	43%	17–19, 30
misc.py	6	5	17%	5–9
TOTAL	1249	680	46%

Tests	Skipped	Failures	Errors	Time
16	0 :zzz:	0 :x:	0 :fire:	5.771s :stopwatch:

github-actions[bot] commented 11 months ago

Coverage for e2e tests for Python 3.12

File	Stmts	Miss	Cover	Missing
server
__init__.py	42	10	76%	12, 15–21, 26, 46, 54
forms.py	82	17	79%	17–20, 43–45, 58–61, 93–98
models.py	153	35	77%	27–30, 56, 59, 62, 88, 92, 95–104, 107, 110, 124, 127–129, 132, 136, 148, 152, 156, 160–161, 167, 187, 190, 211, 214, 228
views.py	336	261	22%	31–36, 49–50, 68–86, 97–99, 108–115, 124, 135–137, 147–165, 175–198, 209–213, 222–244, 253–255, 263–265, 271–293, 299–323, 329–346, 353, 358–360, 365–410, 415–420, 425–435, 440–455, 460–475, 485, 490, 495, 503–504, 510, 515–519
server/controllers
__init__.py	65	37	43%	25–52, 55, 66–86, 89
auth_controllers.py	38	25	34%	13–15, 21–47, 53–55
dev_login_controllers.py	34	23	32%	11–25, 30–39, 44–56
health_controllers.py	13	7	46%	8, 13–18
server/services/auth
__init__.py	28	6	79%	21, 49, 54–55, 60–61
server/services/canvas
__init__.py	51	35	31%	18–25, 29, 33, 37, 47–80, 84
fake_canvas.py	39	26	33%	9, 12, 15, 20–25, 28–29, 37–46, 49–56
server/services/core
assign.py	25	20	20%	16–58
data.py	123	113	8%	9–31, 35–85, 89–92, 96, 100–113, 117–159
server/services/email
__init__.py	30	21	30%	18–59
smtp.py	41	29	29%	15, 23–53
server/services/email/templates
__init__.py	33	23	30%	9–11, 14–17, 20, 30–41, 45–47
server/services/google
__init__.py	54	29	46%	23, 31, 33, 41–44, 48–54, 58–77
server/typings
exception.py	25	9	64%	16–29, 35, 41–42, 51, 54
server/utils
date.py	7	4	43%	17–19, 30
misc.py	6	5	17%	5–9
TOTAL	1249	735	41%

Tests	Skipped	Failures	Errors	Time
8	0 :zzz:	0 :x:	0 :fire:	33.531s :stopwatch:

berkeley-cdss / seating

Feat: Student Room Preference #29

Codecov Report