berkeley-dsep-infra / datahub

JupyterHubs for use by Berkeley enrolled students

https://docs.datahub.berkeley.edu

BSD 3-Clause "New" or "Revised" License

62 stars 37 forks source link

Use overrides methods from KubeSpawner #4831

Open ryanlovett opened 11 months ago

ryanlovett commented 11 months ago

Summary

We apply overrides in our CustomKubeSpawner to change things like memory allocations and mount paths. The upstream KubeSpawner also has methods for doing such things. We should call upstream methods and stop using our own code. Hopefully we can get to a point where we don't need a customer spawner.

I believe the appropriate exposed method is now load_user_options. We may need to override this in our subclass since we do not use forms to set configuration.

User Stories

Where appropriate, we should either upstream our code or use upstream's code. This lessens development and maintenance time.

Acceptance criteria

When we can remove our apply_override method and have the same functionality.

shaneknapp commented 3 months ago

PR to move the spawn delay and timer/patience message upstream: https://github.com/jupyterhub/kubespawner/pull/825