Make AWS role_ref config also lead to .docker/config.json being setup

berkeley-dsep-infra / hubploy

Toolkit to deploy many z2jh based JupyterHubs

BSD 3-Clause "New" or "Revised" License

17 stars 15 forks source link

Make AWS role_ref config also lead to .docker/config.json being setup #100

Closed consideRatio closed 4 years ago

consideRatio commented 4 years ago

I think there is a bug in this section, where we only configure ~/.docker/config.json when providing credentials in one of the two supported ways. I think this should be done independently.

https://github.com/yuvipanda/hubploy/blob/5b4443ff1f4e372c6faf47cb7d6dca363fd61a6f/hubploy/auth.py#L110-L158

consideRatio commented 4 years ago

Fixed by #105