Support --set-string and avoid numerical image tag bug

berkeley-dsep-infra / hubploy

Toolkit to deploy many z2jh based JupyterHubs

BSD 3-Clause "New" or "Revised" License

17 stars 15 forks source link

Support --set-string and avoid numerical image tag bug #68

Closed consideRatio closed 4 years ago

consideRatio commented 4 years ago

When using the helm CLI and --set, it cannot know when it receives it's argument if the value was meant as a string or as an integer if it receives the string 12334567.

The helm CLI has opted to have the --set-string flag to enforce a set value to be a string value even if it looks numerical. We should ensure that we always set image tags and names as strings, or we run into issues like https://github.com/earthlab/hub-ops/pull/199#issuecomment-619099629.

yuvipanda commented 4 years ago

Thanks a lot for digging into this!

I was wondering if we should make '--set' pass through to '--set-string', but being consistent with helm makes better sense.