berkeley-stat159 / project-theta

BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

add calc_t.py #93

Closed pigriver123 closed 8 years ago

pigriver123 commented 8 years ago

I have add a function which is used to compute the t values of beta_gain and beta_loss.

BenjaminHsieh commented 8 years ago

Do you need the following imports? If not, you can delete them from the function file

import matplotlib.pyplot as plt import nibabel as nib import os from stimuli import events2neural from scipy.stats import gamma import math from scipy.stats import mstats from scipy.stats import t

pigriver123 commented 8 years ago

Yeah,you are right.i will correct that

On Tuesday, December 1, 2015, Benjamin Hsieh notifications@github.com wrote:

Do you need the following imports? If not, you can delete them from the function file

import matplotlib.pyplot as plt import nibabel as nib import os from stimuli import events2neural from scipy.stats import gamma import math from scipy.stats import mstats from scipy.stats import t

— Reply to this email directly or view it on GitHub https://github.com/berkeley-stat159/project-theta/pull/93#issuecomment-161134844 .

BenjaminHsieh commented 8 years ago

Also would be good if you can write some comments about the function, see other function scripts for example/format

changsiyao commented 8 years ago

This function is definitely good, just might want to add more comments, like what input, output would be. always good to keep good documentation. Also, like Ben said, you need to import np, but can delete scipy.stats imports.

BenjaminHsieh commented 8 years ago

Let us know if you need any help

BenjaminHsieh commented 8 years ago

Closing this for now because it has not been updated in a while, and so I can do some organization of functions