MRG: Project 3, function to get MLE estimates and function to get matrix_list for whole process

berkeley-stat222 / mousestyles

2016 final project

http://berkeley-stat222.github.io/mousestyles/

BSD 2-Clause "Simplified" License

2 stars 33 forks source link

MRG: Project 3, function to get MLE estimates and function to get matrix_list for whole process #159

Closed harryh1993 closed 8 years ago

harryh1993 commented 8 years ago

@Chenyu-Renee @wyshi @lynnzhao92 @HongfeiZhao @mingyungkim please review my code

coveralls commented 8 years ago

Coverage increased (+3.8%) to 49.955% when pulling 5008d92a69a4799dcd241f90ac436e3819cdddf8 on harryh1993:contributing-issue#144 into 4a83e2dddbb63750d5fda889e2b8306ddbb4275c on berkeley-stat222:master.

harryh1993 commented 8 years ago

thanks guys for your excellent reviews! I will begin to improve my code for each comment and update my code after I finished.

coveralls commented 8 years ago

Coverage increased (+3.8%) to 49.955% when pulling 543afd3beb68d78c8cc71be1807fc0b39556e361 on harryh1993:contributing-issue#144 into 4a83e2dddbb63750d5fda889e2b8306ddbb4275c on berkeley-stat222:master.

harryh1993 commented 8 years ago

@wyshi @mingyungkim @lynnzhao92 @HongfeiZhao @Chenyu-Renee I have updated my code and it passed all the tests. Please take a look at it again and comment any new issues. If everything seems good, I will request Jarrod to merge this pull request.

Chenyu-Renee commented 8 years ago

Hello Harry! I have reviewed again. I think it's ready to go!

wyshi commented 8 years ago

Good job! Now it looks good to me. Thanks!

HongfeiZhao commented 8 years ago

Looks great! I think it can be merged.

harryh1993 commented 8 years ago

@jarrodmillman Would you please take a look at this pull request? My team members have finished reviewing this pull request, and I have addressed previous issues based on their reviews. We think this pull request is now ready to merge. Thanks.