search

berkeley-stat222 / mousestyles

2016 final project
http://berkeley-stat222.github.io/mousestyles/
BSD 2-Clause "Simplified" License
2 stars 33 forks source link

WIP: Togawa28 add path features#122 #167

Closed jarrodmillman closed 8 years ago

jarrodmillman commented 8 years ago

Cherry-picking from #134

Here are my remotes before I started:

$ git remote -v
origin  git@github.com:jarrodmillman/mousestyles.git (fetch)
origin  git@github.com:jarrodmillman/mousestyles.git (push)
upstream        git@github.com:berkeley-stat222/mousestyles.git (fetch)
upstream        git@github.com:berkeley-stat222/mousestyles.git (push)

And here is what I did:

$ git checkout master
$ git pull upstream master
$ git remote add togawa28 git@github.com:togawa28/mousestyles.git
$ git fetch togawa28 add_path_features#122
$ git checkout -b togawa28_add_path_features#122
$ git cherry-pick f68c696 543bbe9 df976c2 b93ccad  8d6f1d9  1b850a2  9569eaa 9c1c50e 82b20a8 
$ git lg
$ git status
$ git push origin togawa28_add_path_features#122

Then I made this pull request.

jarrodmillman commented 8 years ago

I noticed that it appears that an IPython notebook was mistakenly added. I went ahead and removed it.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.07%) to 58.739% when pulling bd7b1f1217a8debc05229e5633ae639867df9cdb on jarrodmillman:togawa28_add_path_features#122 into 9c279b162585d3e7bbd5fa8b65af5135543083d4 on berkeley-stat222:master.

togawa28 commented 8 years ago

@jarrodmillman thanks for your helps! I reviewed the contents of the files, and it looks fine, so please pull them. Should I close the older pull request?

jcpalumbo3 commented 8 years ago

@jarrodmillman The files are correct. Could you please merge the pull request? A couple of our later pull requests require this one before passing. Thank you!