search

berkeley-stat222 / mousestyles

2016 final project
http://berkeley-stat222.github.io/mousestyles/
BSD 2-Clause "Simplified" License
2 stars 33 forks source link

MRG: Add distances plot to report #171

Closed doutib closed 8 years ago

doutib commented 8 years ago

Addresses issue #164

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 55.67% when pulling 209cbc923c87b91a9f9a3ee4b6d0effe7c06cc4e on doutib:contributing-issue-164 into 9c279b162585d3e7bbd5fa8b65af5135543083d4 on berkeley-stat222:master.

doutib commented 8 years ago

@jarrodmillman, the plot does not seem to be displayed in the report. After checking the code several times, I cannot see whether this is an error from me or not. Can you check very quickly and tell me if there is anything is wrong please?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+7.4%) to 63.105% when pulling e4d4d80a8a47d8c03b98386662821f25ed890f2c on doutib:contributing-issue-164 into 9c279b162585d3e7bbd5fa8b65af5135543083d4 on berkeley-stat222:master.

doutib commented 8 years ago

@shamindras do we need to compile the .rst files, or github does it for us? This one does not display my plot.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 63.107% when pulling e34bccaef2f764980c2b5533532aa2c35414b8ed on doutib:contributing-issue-164 into 8369fe44f8707961494c642aee588b9c1791540c on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 63.107% when pulling 368edf75eaa0e30f4c04a89bc33363a704ace800 on doutib:contributing-issue-164 into 8369fe44f8707961494c642aee588b9c1791540c on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 63.107% when pulling d4a161418585f2aaad015495b9911bda5f9587be on doutib:contributing-issue-164 into 8369fe44f8707961494c642aee588b9c1791540c on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 63.107% when pulling d59394bc6ea78f8444a299b8616cd04c90a28a72 on doutib:contributing-issue-164 into 8369fe44f8707961494c642aee588b9c1791540c on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 63.107% when pulling d59394bc6ea78f8444a299b8616cd04c90a28a72 on doutib:contributing-issue-164 into 8369fe44f8707961494c642aee588b9c1791540c on berkeley-stat222:master.

doutib commented 8 years ago

@jarrodmillman Will you be able to help dealing with this issue?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 63.107% when pulling 3e886e4c341035230f8a5d0bfbeebd20c39960c5 on doutib:contributing-issue-164 into 8369fe44f8707961494c642aee588b9c1791540c on berkeley-stat222:master.

doutib commented 8 years ago

I have finally added figures to the figure directory and included them in the rst document. For some reasons the plots are not compiling. I kept the script and the data in the plot dir, in case we want to see how it is generated.

I believe we are able to merge now.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 64.414% when pulling a13eefe7431e6eccbc271946df878f60befbe335 on doutib:contributing-issue-164 into 5cc92835424905375f56ee90b9e2f70c6cde4455 on berkeley-stat222:master.

jarrodmillman commented 8 years ago

@doutib Sorry I missed your earlier question. I am just getting caught up on things now.

I merged another pull request since you last rebased. Please rebase and I will merge this.

By the way, how did you try to compile the plots? You should just be able to type

$ cd doc/source/
$ make html

to generate the HTML page and

$ cd doc/source/
$ make latexpdf

to generate the PDF.

Both the commands will generate the plots using the plot directive. You can see the code I use to do that here:

$ cat _sphinxext/plot_directive.py

Is this what you were doing? If so, what error message did you get?

You don't need to change anything (i.e., other than rebasing this), I am just curious.

doutib commented 8 years ago

@jarrodmillman No worries, I tried with the make html command and nothing appears on the document excepted for a "Source code" link which provides me the python code I use to generate the plot...

I ll rebase asap.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 64.414% when pulling 1b4ca16fd079ba9c114a853d26dc5d1e4a681bee on doutib:contributing-issue-164 into 67bdb6692f6e64d54dd63ce3edb7480eb4a1d6a3 on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 64.414% when pulling 1b4ca16fd079ba9c114a853d26dc5d1e4a681bee on doutib:contributing-issue-164 into 67bdb6692f6e64d54dd63ce3edb7480eb4a1d6a3 on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 64.414% when pulling 1b4ca16fd079ba9c114a853d26dc5d1e4a681bee on doutib:contributing-issue-164 into 67bdb6692f6e64d54dd63ce3edb7480eb4a1d6a3 on berkeley-stat222:master.

doutib commented 8 years ago

@jarrodmillman rebasing done.

jarrodmillman commented 8 years ago

@doutib I am not sure what happened, but something is weird about your "rebase". It added 2 commits from HongfeiZhao. It also didn't update you with master. " This branch is 9 commits ahead, 10 commits behind berkeley-stat222:master" according to: https://github.com/doutib/mousestyles/tree/contributing-issue-164

Anyway, I cherry picked your commits and created a new pull request #187. Once the tests pass I will merge that one instead of this one to keep the history nice.